fix(inspect): clarify engine-view content-gate behavior#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the
inspectengine-view UX for thev0.1.6release by clarifying that--content-gatedoes not affect raw engine inspection output.What Changed
inspect --view engineas a raw WASM engine/sample/remap surfaceInfo:note on stderr when engine view is used with:--content-gate ...standardandjsoninspect output--content-gateas pipeline-policy inspection behaviorWhy
inspect --view enginewas already intentionally raw, but the CLI accepted--content-gate ...without explaining that the flag does not affect engine-view output. That made the feature look misleading, especially when users expected gate restrictions to show up there.This change keeps the raw engine contract intact and adds a direct CLI explanation that points users to
--view pipelinefor eligibility,contentGate, acceptance, and fallback diagnosis.Testing
Passed:
bun test test/command-inspect.test.ts test/command-config-inspect.test.tsCoverage added/updated for:
--content-gate defaulton engine viewRelease Note
This is intended for
v0.1.6.User-facing impact:
inspect --view enginenow explains whencontentGatedoes not apply