refactor: consolidate target hostname and path validation - #10
Open
devUmut35 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hostname and origin-relative path validation were duplicated across three modules with slightly different messages:
scanner.pyvalidated hostnames after IDN encodingnetwork.pynormalized + validated hostnames itselfpolicy.pyre-implemented both hostname normalization and path validationThis PR extracts one canonical implementation into a new
previewshield.targetsmodule:normalize_hostname()- IDN normalization, IP compression, label/length checks (raisesValueError)normalize_origin_paths()- safe origin-relative route parsing, query preservation, deduplicationEach caller keeps its own public error contract (
ConfigurationErrorfor scanner/policy,NetworkSafetyErrorfor network) by translating the sharedValueError.Net result: 19 insertions / 90 deletions of duplicated safety logic removed.
Behavior compatibility
%-bearing and underscore hostnames with the same message as before.Verification
python -m pytest→ 195 passedpython -m ruff check src tests→ cleanpython -m ruff format --check src tests→ clean