Skip to content

bug fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devandapaige merged 1 commit into from
Nov 12, 2025
Merged

bug fix #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/blog/BlogContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export function BlogContent({ posts }: BlogContentProps) {
if (selectedTag) {
params.set('tag', selectedTag)
}
if (searchQuery) {
params.set('search', searchQuery)
if (searchQuery.trim()) {
params.set('search', searchQuery.trim())
}
const queryString = params.toString()
router.replace(queryString ? `?${queryString}` : '?')
Expand Down Expand Up @@ -119,7 +119,7 @@ export function BlogContent({ posts }: BlogContentProps) {
<circle cx="11" cy="11" r="8" />
<path d="m21 21-4.35-4.35" />
</svg>
{searchQuery && (
{searchQuery.trim() && (
Copy link
Copy Markdown

@cursor cursor Bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: UI Inconsistency: Clear Button Missing

The clear button is now hidden when the search input contains only whitespace characters because the condition checks searchQuery.trim() while the input value is bound to the untrimmed searchQuery. Users typing only spaces see text in the input but no way to clear it, creating an inconsistent UI state.

Fix in Cursor Fix in Web

<button
onClick={() => setSearchQuery('')}
className="absolute right-4 top-1/2 transform -translate-y-1/2 text-white/50 hover:text-white transition-colors"
Expand All @@ -142,9 +142,9 @@ export function BlogContent({ posts }: BlogContentProps) {
</button>
)}
</div>
{searchQuery && (
{searchQuery.trim() && (
<p className="mt-2 text-sm text-white/60">
Found {filteredPosts.length} {filteredPosts.length === 1 ? 'post' : 'posts'} matching &quot;{searchQuery}&quot;
Found {filteredPosts.length} {filteredPosts.length === 1 ? 'post' : 'posts'} matching &quot;{searchQuery.trim()}&quot;
</p>
)}
</div>
Expand All @@ -158,7 +158,7 @@ export function BlogContent({ posts }: BlogContentProps) {
<div className="text-center py-12">
<p className="text-xl text-white/80 mb-2">No posts found</p>
<p className="text-white/60">
{searchQuery || selectedTag
{searchQuery.trim() || selectedTag
? 'Try adjusting your search or filter criteria'
: 'No blog posts available'}
</p>
Expand Down
Loading