Skip to content

New features: date localization, week starts with & text color for months and days #26

Open
Eimji wants to merge 7 commits into
devappmin:mainfrom
Eimji:main
Open

New features: date localization, week starts with & text color for months and days #26
Eimji wants to merge 7 commits into
devappmin:mainfrom
Eimji:main

Conversation

@Eimji

@Eimji Eimji commented Oct 30, 2023

Copy link
Copy Markdown

Hello

Thanks for your great package.
I would like to submit the following changes:

  • date localization (months & week days)
  • new option to specify wich day the week should start (weekStartsWith = 1 for Monday, ..., weekStartsWith = 7 for Sunday)
  • new option to set a separate color for month and day labels in the HeatMap widget
  • update the example app

Please merge my PR as it will fix the following issues
#25
#18
#10
#17
#8

Thanks

@Sun3

Sun3 commented Feb 6, 2024

Copy link
Copy Markdown

Can you give an estimated date when these features will be released? I am really interested in week day starts on Sunday or Monday feature.

Thanks.

@rmsmani rmsmani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the screenshots of the fix

@Eimji

Eimji commented Feb 17, 2024

Copy link
Copy Markdown
Author

@rmsmani you want me to add screenshots for which features ? Not sure to understand.

Thanks

@rmsmani

rmsmani commented Feb 17, 2024

Copy link
Copy Markdown

For the new features which were developed by you....

@Eimji

Eimji commented Feb 18, 2024

Copy link
Copy Markdown
Author

For the new features which were developed by you....

Clone my fork, and you can try the example application to see the new features. No need for screenshots.

@rmsmani rmsmani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good to have the screen shot in the PR for future reference.

@fodil-a

fodil-a commented Jun 14, 2024

Copy link
Copy Markdown

this should've been fixed, what can be done to merge it ?

@nkolatsis

Copy link
Copy Markdown

So is this getting released or not? @rmsmani

@rmsmani

rmsmani commented Oct 2, 2024

Copy link
Copy Markdown

Repo owner should accept the pr

@nkolatsis

Copy link
Copy Markdown

Repo owner should accept the pr

@Eimji now you

@brandonguigo

Copy link
Copy Markdown

Hi there, any news on this feature ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants