Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements related to visitor profiles, user and site management, and reporting. The main changes include the introduction of the
VisitorProfileentity, enhancements to user and visitor management services, and the addition of new services for handling sites and zones. Below are the most important changes grouped by theme:Visitor Profile Management:
VisitorProfileentity, ensuring unique visitor profiles per site and phone number, and updated theVisitorentity to referenceVisitorProfile. [1] [2]VisitorProfileRepositoryfor data access, including methods to find and check existence by site and phone number.VisitorServiceto associate visitors with profiles, create profiles if missing, and provide a method to update visitor profiles with validation. [1] [2]VisitorProfilefor more accurate results.User Management Enhancements:
UserServicewith methods to list, retrieve, update, activate, deactivate users, and change passwords, including role and site-based access control.Site and Zone Management:
SiteServiceandZoneServicefor full CRUD operations on sites and zones, with business rules to prevent duplicates and ensure proper site/zone relationships. [1] [2]Reporting:
ReportServiceto export visitor data as CSV, including visit details and durations.General Improvements:
These changes collectively improve the data model, enforce business rules, and add essential features for managing visitors, users, sites, and zones.