fix: ability to stop and save running hidden worklogs#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the user experience when stopping a timer on a hidden Jira ticket. The main improvement is that stopping a hidden timer now also saves the worklog to Jira, ensures a minimum logged time, and provides user feedback for unusually long sessions. The UI is updated to reflect this change and to show a loading state during the save process.
Timer and Worklog Handling
handleStopHiddenTimerfunction that saves the worklog to Jira (usingaddWorklog), ensures at least 1 minute is logged, warns the user if the session exceeds 8 hours, and removes any draft description from local storage. (src/components/TicketList.tsx, src/components/TicketList.tsxR109-R135)handleStopHiddenTimer, display a loading state while saving, and change the button label to "Stop & Save". (src/components/TicketList.tsx, src/components/TicketList.tsxL560-R594)State Management
stoppingHiddenstate variable to manage the loading indicator for the stop button. (src/components/TicketList.tsx, src/components/TicketList.tsxR44)Imports
addWorklogfunction from the Jira API library to support worklog saving. (src/components/TicketList.tsx, src/components/TicketList.tsxL3-R3)