Fix/scripture moment no verses#263
Merged
Merged
Conversation
- Implement "Deeper Connections" section to display `scriptureConnections` using `_ConnectionTile` components - Wrap new elements in `_DelayedEntry` to provide staggered entry animations - Adjust the animation delay for `revelationKey` to 800ms to maintain the visual sequence
- Extract repeated scripture connections UI logic into a new `_ScriptureConnectionsSection` widget - Replace duplicate implementations across encounter card variants with the new component to improve maintainability and reduce code duplication
- Implement "Deeper Connections" section to display `scriptureConnections` using `_ConnectionTile` components - Wrap new elements in `_DelayedEntry` to provide staggered entry animations - Adjust the animation delay for `revelationKey` to 800ms to maintain the visual sequence
Adds a single source of truth for which EncounterCard fields each card type renders, plus a debug-only check that flags content authored in JSON but never wired to a renderer — closing the "silently dropped field" bug class confirmed in production content (woman_well_en_001.json: revelation_key on character_moment cards, never rendered before this fix was found to already exist; title/subtitle never rendered on scripture_moment). - Add lib/models/encounter_card_contract.dart: kEncounterCardRenderedFields (per-type rendered-field sets) + kDeferredEncounterCardFields (ambientSound, haptic, celebrationType — documented as future implementation, not gaps) - Add debug-only _debugCheckEncounterCardContract() in EncounterCard.fromJson — warns via debugPrint when a card has non-null content with no renderer registered for its type. Zero production cost (gated on kDebugMode). - Add field-level doc comments on EncounterCard documenting render status per field - Fix: ScriptureMomentCard now renders title/subtitle (previously silently dropped) - Fix: InteractiveMomentCard now renders revelationKey (previously silently dropped) - Verified: CharacterMomentCard already rendered revelationKey correctly — no change needed, confirmed via grep against contract No changes to JSON content shape or existing verse mechanisms (verseOverlay, scriptureConnections, verseReference/verseText) — this is rendering-layer only, scoped per discussion. Verification: dart format (0 changed), dart fix --apply (nothing to fix), flutter analyze --fatal-infos (no issues). Real-device pass pending — note neither scripture_moment card in woman_well_en_001.json currently has title/subtitle authored, so that specific rendering path needs verification against different content or a local test edit. Glory to God 🙏
…into fix/SCRIPTURE_MOMENT-no-verses
Contributor
🎉 CI Results for PR #263🔄 Static Analysis:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.