Add support for IAM based Auth#42
Open
rehan-fr wants to merge 4 commits intodevelopmentforpeople:developfrom
Open
Add support for IAM based Auth#42rehan-fr wants to merge 4 commits intodevelopmentforpeople:developfrom
rehan-fr wants to merge 4 commits intodevelopmentforpeople:developfrom
Conversation
Author
|
@developmentforpeople Would love to know your thoughts on this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key based auth i.e. (Access key & secret) is generally avoided in production environments due to inherent risks and overhead (key rotation etc).
This PR refactors the auth part by keeping the current key based auth but also giving an option through a drop down to select IAM based auth. This makes use of auth providers already packaged in minio.
In IAM based auth if an instance (EC2 etc) that hosts the application, has IAM profile attached that gives it access to the S3, will just work with DFP External Storage without requiring any keys.