Fix: Cannot query child DocType directly via frappe.db.get_list#43
Open
TubaApollo wants to merge 1 commit intodevelopmentforpeople:developfrom
Open
Fix: Cannot query child DocType directly via frappe.db.get_list#43TubaApollo wants to merge 1 commit intodevelopmentforpeople:developfrom
TubaApollo wants to merge 1 commit intodevelopmentforpeople:developfrom
Conversation
The JavaScript code was trying to query 'DFP External Storage by Folder' directly using frappe.db.get_list(), but child DocTypes (istable=1) cannot be queried directly. This caused the error: "DFP External Storage by Folder is not a valid parent DocType for DFP External Storage by Folder" Solution: - Added a whitelisted Python method `get_assigned_folders()` that queries the child table properly - Updated JavaScript to use frappe.call() with the new method instead of frappe.db.get_list() Fixes developmentforpeople#33 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript code was trying to query 'DFP External Storage by Folder' directly using frappe.db.get_list(), but child DocTypes (istable=1) cannot be queried directly. This caused the error:
"DFP External Storage by Folder is not a valid parent DocType for DFP External Storage by Folder"
Solution:
get_assigned_folders()that queries the child table properlyFixes #33
🤖 Generated with Claude Code