chore: cleanup v4#30
Open
alukach wants to merge 2 commits into
Open
Conversation
alukach
force-pushed
the
fix/v4-pre-publish-cleanup
branch
from
0724995 to
12a7fd6
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small cleanups noticed while preparing to consume
@devseed-ui/collecticons-chakra@4from another repo. Neither is blocking —4.0.0is already published to npm and works. Land at your convenience.<svg>wrapper inside<Icon>incollecticon-creator.tsx. Chakra v3's<Icon>is itself an<svg>, so the inner wrapper was producing<svg><svg/></svg>markup in the DOM. Renders fine in practice; React 19 may emit a console warning on the invalid nesting.@chakra-ui/reactand@emotion/reactfromdependenciestopeerDependenciesonly. They were listed in both. The duplication can cause consumer trees to install a second copy of Chakra/Emotion alongside the app's, which is the kind of thing that contributes to context-mismatch issues (e.g. duplicate React copies). Peer-only is the conventional shape for UI library packages.Test plan
ts-checkcleanbuildsucceeds