fix: CORS error and restore PWA manifest functionality respecting auth redirects for subpath deployments.#63
Open
fix: CORS error and restore PWA manifest functionality respecting auth redirects for subpath deployments.#63
Conversation
…h redirects for subpath deployments.
ad17356 to
e29b0df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I get an error like this:
This PR attempt to fix this CORS error and PWA manifest functionality for subpath deployments by changing how
PUBLIC_URLis handled:/asPUBLIC_URLand convert hardcoded paths to runtime placeholdersdocker-entrypoint.shgetBasePath()andgetRedirectUri()utilities to properly handle Keycloak redirects for subpath deploymentsThis ensures manifest files, assets, and authentication work correctly whether deployed at root (
/) or a subpath (/manager/).