Conversation
AliceR
approved these changes
Mar 13, 2026
Member
AliceR
left a comment
AliceR
left a comment
There was a problem hiding this comment.
Thanks @alukach, this definitely looks like a very good simplification! I did not run the code, but looks a straightforward change.
Not sure about that GET header removal, but the temporary promise in line 93 was authored on Jul 4, 2025... shouldn't we update stac-react to v1, anyways?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
In this PR, we attempt to reduce lines of code and simplify the codebase for the sake of legibility of
client/src/main.tsxHow I did it
.last()prototype for arrays. I was unable to find its usage anywhere.content-typebug was resolved in developmentseed/stac-react@26b7636