Skip to content

fix: repair db benches (Schema API) + auto-format generated code#361

Merged
Iamdavidonuh merged 1 commit into
mainfrom
fix/bench-schema-compile
Jul 5, 2026
Merged

fix: repair db benches (Schema API) + auto-format generated code#361
Iamdavidonuh merged 1 commit into
mainfrom
fix/bench-schema-compile

Conversation

@Iamdavidonuh

Copy link
Copy Markdown
Collaborator

Repairs the memory_profile/persistence benches broken by the Schema arg (#343), makes types/build.rs rustfmt its generated output so plain builds stop emitting a formatting-only diff, and adds a cargo build --benches CI step to catch bench rot.

@Iamdavidonuh Iamdavidonuh requested a review from deven96 July 4, 2026 14:18
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Test Results

442 tests   442 ✅  19m 44s ⏱️
 42 suites    0 💤
  4 files      0 ❌

Results for commit 400f53a.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
predicate_query_with_index/size_100                          1.00      3.1±0.01µs        ? ?/sec    1.00      3.2±0.01µs        ? ?/sec
predicate_query_with_index/size_1000                         1.00     31.8±0.11µs        ? ?/sec    1.04     33.0±0.15µs        ? ?/sec
predicate_query_with_index/size_10000                        1.00    398.3±0.54µs        ? ?/sec    1.00    398.7±0.89µs        ? ?/sec
predicate_query_with_index/size_100000                       1.29      6.2±0.44ms        ? ?/sec    1.00      4.9±0.02ms        ? ?/sec
predicate_query_without_index/size_100                       1.00      6.8±0.02µs        ? ?/sec    1.01      6.9±0.02µs        ? ?/sec
predicate_query_without_index/size_1000                      1.00     99.2±0.73µs        ? ?/sec    1.05    104.2±0.26µs        ? ?/sec
predicate_query_without_index/size_10000                     1.02    779.5±1.94µs        ? ?/sec    1.00    767.4±3.96µs        ? ?/sec
predicate_query_without_index/size_100000                    1.53     18.9±0.58ms        ? ?/sec    1.00     12.3±0.04ms        ? ?/sec
store_batch_insertion_without_predicates/size_100            1.01    193.3±3.24µs        ? ?/sec    1.00    192.3±4.09µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.00  1245.1±10.26µs        ? ?/sec    1.00  1240.8±15.03µs        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.01     13.8±0.19ms        ? ?/sec    1.00     13.8±0.15ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.02    137.7±0.50ms        ? ?/sec    1.00    135.1±0.71ms        ? ?/sec
store_retrieval_linear_cosine_similarity/size_100            1.00     83.6±0.58µs        ? ?/sec    1.01     84.2±0.76µs        ? ?/sec
store_retrieval_linear_cosine_similarity/size_1000           1.00    718.5±6.25µs        ? ?/sec    1.00    715.4±5.97µs        ? ?/sec
store_retrieval_linear_cosine_similarity/size_10000          1.00      7.2±0.06ms        ? ?/sec    1.01      7.3±0.10ms        ? ?/sec
store_retrieval_linear_cosine_similarity/size_100000         1.00     75.0±0.31ms        ? ?/sec    1.02     76.2±0.35ms        ? ?/sec
store_retrieval_linear_dot_product/size_100                  1.00     82.8±0.47µs        ? ?/sec    1.00     83.1±0.39µs        ? ?/sec
store_retrieval_linear_dot_product/size_1000                 1.01    711.6±6.81µs        ? ?/sec    1.00    707.5±4.75µs        ? ?/sec
store_retrieval_linear_dot_product/size_10000                1.00      7.0±0.03ms        ? ?/sec    1.02      7.1±0.05ms        ? ?/sec
store_retrieval_linear_dot_product/size_100000               1.00     73.0±0.35ms        ? ?/sec    1.02     74.6±0.32ms        ? ?/sec
store_retrieval_linear_euclidean_distance/size_100           1.01     83.4±0.75µs        ? ?/sec    1.00     83.0±0.34µs        ? ?/sec
store_retrieval_linear_euclidean_distance/size_1000          1.00    712.6±6.70µs        ? ?/sec    1.00    709.7±5.25µs        ? ?/sec
store_retrieval_linear_euclidean_distance/size_10000         1.04      7.3±0.04ms        ? ?/sec    1.00      7.1±0.02ms        ? ?/sec
store_retrieval_linear_euclidean_distance/size_100000        1.01     74.9±0.16ms        ? ?/sec    1.00     74.4±0.21ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.00     83.8±0.63µs        ? ?/sec    1.00     83.5±0.31µs        ? ?/sec
store_retrieval_no_condition/size_1000                       1.00    723.0±5.90µs        ? ?/sec    1.00    719.7±4.67µs        ? ?/sec
store_retrieval_no_condition/size_10000                      1.00      7.1±0.07ms        ? ?/sec    1.00      7.1±0.04ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.01     76.6±0.28ms        ? ?/sec    1.00     75.7±0.48ms        ? ?/sec
store_retrieval_non_linear_hnsw/size_100                     1.01    165.1±0.73µs        ? ?/sec    1.00    163.2±0.85µs        ? ?/sec
store_retrieval_non_linear_hnsw/size_1000                    1.00    448.8±0.67µs        ? ?/sec    1.04    465.1±1.57µs        ? ?/sec
store_retrieval_non_linear_hnsw/size_10000                   1.00  1661.2±19.10µs        ? ?/sec    1.13  1874.3±48.47µs        ? ?/sec
store_retrieval_non_linear_hnsw/size_100000                  1.00     11.3±0.51ms        ? ?/sec    1.03     11.7±0.45ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.00    177.8±0.36µs        ? ?/sec    1.00    178.1±0.60µs        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00   1147.7±2.21µs        ? ?/sec    1.00   1149.1±2.42µs        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.05     13.2±0.30ms        ? ?/sec    1.00     12.7±0.30ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.03    151.4±0.61ms        ? ?/sec    1.00    147.4±0.61ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.01    283.6±1.91µs        ? ?/sec    1.00    279.5±0.80µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.01      2.7±0.01ms        ? ?/sec    1.00      2.7±0.01ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.01     27.4±0.09ms        ? ?/sec    1.00     27.2±0.09ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.01    275.8±0.67ms        ? ?/sec    1.00    273.0±1.56ms        ? ?/sec

Add &Schema::default() to the broken benches, rustfmt generated code in build.rs to kill regen churn, and compile-check benches in CI.
@Iamdavidonuh Iamdavidonuh force-pushed the fix/bench-schema-compile branch from 6cf7337 to 400f53a Compare July 5, 2026 17:56
@Iamdavidonuh Iamdavidonuh merged commit dca420e into main Jul 5, 2026
6 of 7 checks passed
@Iamdavidonuh Iamdavidonuh deleted the fix/bench-schema-compile branch July 5, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants