Repository navigation
refactor(watch): Remove runtime config and improve client error handling #210
Description
Summary
This PR refactors the Watch feature to simplify configuration and improve reliability:
- Remove runtime
watch.enabledconfig - Watch is now controlled purely by compile-time feature flag - Add sentinel error to gRPC watch streams - Clients receive explicit
UNAVAILABLEerror on server shutdown - Comprehensive reliability documentation - Production-ready reconnection patterns and error handling guides
- Clarified test strategy - Focus on Watch code correctness, defer Raft integration tests
Motivation
Problem 1: Confusing configuration
- Having both compile-time feature flag AND runtime config was redundant
- Users had to enable watch in two places (Cargo.toml + config file)
- Principle: "If compiled, it must be used"
Problem 2: Silent stream closure
- gRPC watch streams ended with
Ok(None)on server crash - Clients couldn't distinguish "no more events" from "server died"
- No guidance on reconnection logic
Problem 3: Over-scoped test plan
- Initial strategy included Raft integration tests (Leader election, network partition)
- These test Raft correctness, not Watch correctness
- Watch simply listens to
StateMachine.apply()- Raft guarantees apply's correctness
Changes
1. Configuration Simplification
Before:
# Cargo.toml
d-engine = { features = ["watch"] }
# config/raft.toml
[raft.watch]
enabled = true # ← Redundant!
event_queue_size = 1000
Activity
coderabbitai commentedon Dec 20, 2025
📝 CodeRabbit Plan Mode
Generate an implementation plan and prompts that you can use with your favorite coding agent.
Examples
🔗 Similar Issues
Related Issues
make test-all#197🔗 Related PRs
#130 - doc #129: update README to align with v0.1.3 [merged]
#149 - V0.1.4 release [merged]
#176 - Feature/172 ttl support [merged]
#177 - feat #174: Implement lock-free Watch mechanism for real-time key monitoring [merged]
#199 - Feature/196 client watch [merged]
👤 Suggested Assignees
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:💬 Have feedback or questions? Drop into our discord or schedule a call!
refactor(watch): #210: Simplify architecture and remove runtime config
refactor(watch) #210: simplify benchmark and fix conditional compilation
fix(clippy) #210: resolve compilation errors and linting warnings
refactor(raft) #209: Architecture review - consolidate v0.2.0 improve…
feat #204: Release v0.2.0 - Production-ready distributed coordination…