Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/ISSUE_TEMPLATE/blank.md

This file was deleted.

71 changes: 59 additions & 12 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,67 @@
---
name: Feature Request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''
about: Propose a feature based on real production needs
title: "[Feature] "
labels: "enhancement"
assignees: ""
---

## ⚠️ Read First

d-engine follows the **20/80 rule** - we build features that solve 80% of users' problems, not edge cases.

**Before submitting:**

- [ ] This solves a **real production problem** (not "it would be nice")
- [ ] I've checked existing features don't solve this

Features that don't meet this bar will be deferred or declined.

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is.
## Production Context

**What production problem does this solve?**
(Be specific: "Our company runs d-engine for X and hits Y problem daily")

**Who is affected?**

- [ ] Most embedded mode users
- [ ] Most standalone mode users
- [ ] Specific industry/scale (describe below)

**Current workaround:**
(What are you doing now? Why is it insufficient?)

---

**Describe the solution you'd like**
A clear and concise description of what you want to happen.
## Proposed Solution

**Your solution:**

**Why is this the simplest approach?**
(d-engine values simplicity - explain why this doesn't bloat the API)

---

## Impact vs Complexity

**Benefits:**

- Performance impact: (quantify if possible)
- User pain reduced: (describe)

**Complexity added:**

- [ ] New public APIs
- [ ] More config options
- [ ] Additional dependencies
- [ ] Increased testing surface

---

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
## Additional Context

**Additional context**
Add any other context or screenshots about the feature request here.
- Benchmarks/measurements (if performance-related)
- Similar features in etcd/consul (if applicable)
- Your willingness to contribute code
76 changes: 67 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,72 @@
## What Does This PR Do?

## Type
- [ ] New feature
- [ ] Bug Fix
(1-2 sentence summary)

## Description
Briefly describe the purpose of this PR:
**Type:**

## Related Issues
- Close Issue: #123
- [ ] Bug Fix (with test)
- [ ] Feature (issue #\_\_\_ approved)
- [ ] Documentation
- [ ] Test/Coverage
- [ ] Performance (with benchmark)

---

## Why Is This Needed?

**For features:** Link to approved issue #\_\_\_

**For bugs:** Describe the problem and how this fixes it

---

## Checklist
- [ ] The code has been tested locally (unit test or integration test)
- [ ] Squash down commits to one or two logical commits which clearly describe the work you've done.

**Required:**

- [ ] `make test` passes
- [ ] Added tests for new code
- [ ] Commits squashed to 1-2 logical units

**If changing APIs:**

- [ ] Updated relevant docs
- [ ] Explained why complexity is justified

---

## Testing

**How tested:**

- Unit tests: (describe)
- Integration tests: (if applicable)
- Manual testing: (if applicable)

**For bug fixes:**

- [ ] Added test that fails without this fix

**For performance improvements:**

- [ ] Included benchmark showing improvement

---

## Does This Follow d-engine's Principles?

- [ ] Solves a real problem for most users (not just my edge case)
- [ ] Keeps implementation simple
- [ ] Doesn't bloat the API surface

---

## Reviewer Notes

(Optional: anything reviewers should focus on)

**Estimated review complexity:**

- [ ] Quick (< 100 lines)
- [ ] Medium (< 300 lines)
- [ ] Deep (> 300 lines)
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ jobs:
with:
fetch-depth: 0

- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
tool-cache: false
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: false
Comment thread
JoshuaChi marked this conversation as resolved.

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@master
with:
Expand Down
Loading