Repository navigation
fix #12: github docker release script - #13
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Docker release workflow validates versions before builds, captures digests from pushed images, and creates manifests from explicit digest references. Docker CI now runs for every pull request. ChangesDocker workflows
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/docker-release.yml:
- Around line 16-18: Update the workflow concurrency group expression near the
top of docker-release.yml to use the same normalized version value as the
publish step, stripping any leading “v” from release tags and inputs so
equivalent releases share one key. Preserve cancel-in-progress: false and ensure
v1.2.3 and 1.2.3 cannot run concurrently.
- Around line 121-133: Update the push step’s digest extraction to capture the
complete docker push output, collect all matching sha256 digests into an array,
and require exactly one match before writing the digest to GITHUB_OUTPUT. Fail
with a clear error when the match count is zero or greater than one, and
preserve the single digest for the existing Export digest step.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8ad2eda9-4ee7-4e22-86a0-f2cd9735d3ba
📒 Files selected for processing (1)
.github/workflows/docker-release.yml
…gest failures and concurrent-release races
… check stuck on path filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores