fix: skip tracks Spotify refuses an audio key for instead of freezing#319
Open
JaragonCR wants to merge 1 commit into
Open
fix: skip tracks Spotify refuses an audio key for instead of freezing#319JaragonCR wants to merge 1 commit into
JaragonCR wants to merge 1 commit into
Conversation
Spotify makes a per-track, context-dependent decision on granting the legacy AES audio key. License-gated tracks are refused (AesKeyError, e.g. code 1) during ordinary playlist/transfer playback even though they play on official clients, which establish a licensed context. go-librespot only implements the legacy key path, so a refused track currently freezes the player with no way forward. Treat a refused key (audio.KeyProviderError) like restricted/unsupported media: skip forward to the first playable track. Covers all load paths — loadContext, transfer/cast (via a shared loadCurrentTrackOrSkip helper), and advanceNext — and bounds the forward walk with consecutiveUnplayableSkips (cap 50) so a fully-gated or RepeatingContext context advances to the first playable track instead of looping forever. This is a mitigation; the real fix is implementing the modern PlayPlay license flow. Tracked separately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotify makes a per-track, context-dependent decision on granting the legacy AES audio key. License-gated tracks are refused (AesKeyError, e.g. code 1) during ordinary playlist/transfer playback even though they play on official clients, which establish a licensed context. go-librespot only implements the legacy key path, so a refused track currently freezes the player with no way forward.
Treat a refused key (audio.KeyProviderError) like restricted/unsupported media: skip forward to the first playable track. Covers all load paths — loadContext, transfer/cast (via a shared loadCurrentTrackOrSkip helper), and advanceNext — and bounds the forward walk with consecutiveUnplayableSkips (cap 50) so a fully-gated or RepeatingContext context advances to the first playable track instead of looping forever.
This is a mitigation; the real fix is implementing the modern PlayPlay license flow which is currently impossible due to takedowns.