feat(rps): display structured per-component activation result#1349
Draft
madhavilosetty-intel wants to merge 1 commit into
Draft
feat(rps): display structured per-component activation result#1349madhavilosetty-intel wants to merge 1 commit into
madhavilosetty-intel wants to merge 1 commit into
Conversation
madhavilosetty-intel
force-pushed
the
feat/2665-structured-provisioning-result
branch
from
63d1686 to
d327bce
Compare
Parse and surface the structured per-component provisioning result that RPS now sends (rps#2665). When the success message includes the additive Components object, log each component (Activation, Wired/ Wireless Network, TLS, CIRA Proxy/Connection) with its result and details, logging failures at error level. When Components is absent (older RPS), fall back to the existing flat status lines, so behavior against older servers is unchanged. Refs device-management-toolkit/rps#2665
madhavilosetty-intel
force-pushed
the
feat/2665-structured-provisioning-result
branch
from
d327bce to
8afb2e0
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the RPS client activation-status reporting to parse and surface the new structured, per-component provisioning results returned by newer RPS versions, while keeping legacy logging behavior for older RPS responses.
Changes:
- Parse and log the new
Componentsobject in RPS “success” status messages, logging each component result individually. - Add new message types (
ComponentResult,ComponentResults) to represent structured activation results. - Add tests covering structured-success parsing and basic structured/legacy logging paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/rps/rps.go | Replaces flat status logging with structured per-component logging when Components is present, with legacy fallback. |
| internal/rps/rps_test.go | Adds tests for structured success handling and for calling the new logging helper without panics. |
| internal/rps/message.go | Extends StatusMessage with Components and introduces structured component result structs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+267
to
+271
| if statusMessage.Components != nil { | ||
| c := statusMessage.Components | ||
| logComponentResult("Activation", c.Activation) | ||
| logComponentResult("Wired Network", c.WiredNetwork) | ||
| logComponentResult("Wireless Network", c.WirelessNetwork) |
Contributor
There was a problem hiding this comment.
Looks to be valid suggestion. Please check
Comment on lines
+291
to
+294
| line := label + ": " + result.Result | ||
| if result.Details != "" { | ||
| line += " (" + result.Details + ")" | ||
| } |
Comment on lines
+242
to
+245
| func TestLogStatusMessageStructured(t *testing.T) { | ||
| // Structured Components present: per-component lines are logged, no panic. | ||
| statusMessage := StatusMessage{ | ||
| Status: "Admin control mode.", |
sudhir-intc
reviewed
Jun 3, 2026
Contributor
sudhir-intc
left a comment
sudhir-intc
left a comment
There was a problem hiding this comment.
Please do address the copilot review comments
Comment on lines
+267
to
+271
| if statusMessage.Components != nil { | ||
| c := statusMessage.Components | ||
| logComponentResult("Activation", c.Activation) | ||
| logComponentResult("Wired Network", c.WiredNetwork) | ||
| logComponentResult("Wireless Network", c.WirelessNetwork) |
Contributor
There was a problem hiding this comment.
Looks to be valid suggestion. Please check
sudhir-intc
reviewed
Jun 3, 2026
| if result.Result == "Failure" { | ||
| log.Error(line) | ||
| } else { | ||
| log.Info(line) |
Contributor
There was a problem hiding this comment.
I tried your PR and don't see new info lines getting logged.
I see the following output, which is same as 2.x.x branch. Am I missing something here ?
sudo ./rpc-2665 activate -u wss://10.190.213.16/activate -n --profile acmProfileCloud --tls-tunnel --password <password>
time="2026-06-03T14:53:26+05:30" level=info msg="connecting to wss://10.190.213.16/activate"
time="2026-06-03T14:53:26+05:30" level=info msg="connected to wss://10.190.213.16/activate"
time="2026-06-03T14:54:43+05:30" level=info msg="Status: Admin control mode."
time="2026-06-03T14:54:43+05:30" level=info msg="Network: Wired Network Configured"
time="2026-06-03T14:54:43+05:30" level=info msg="CIRA: Configured"
time="2026-06-03T14:54:43+05:30" level=info msg="TLS: unconfigured"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse and surface the structured per-component provisioning result that RPS now sends (rps#2665). When the success message includes the additive Components object, log each component (Activation, Wired/ Wireless Network, TLS, CIRA Proxy/Connection) with its result and details, logging failures at error level. When Components is absent (older RPS), fall back to the existing flat status lines, so behavior against older servers is unchanged.
Refs device-management-toolkit/rps#2665