feat: auto-register device on 404 for unactivated devices#1369
Draft
sinchubhat wants to merge 1 commit into
Draft
feat: auto-register device on 404 for unactivated devices#1369sinchubhat wants to merge 1 commit into
sinchubhat wants to merge 1 commit into
Conversation
* When rpc amtinfo --sync sends a PATCH to console for a device that is not yet registered, sync currently fails with: "device not found; activate the device before syncing device info". * Handle 404 by creating a minimal device record (guid + hostname) via POST, then retry PATCH with the full deviceInfo payload. Addresses #1368
There was a problem hiding this comment.
Pull request overview
Adds a 404 recovery path to rpc amtinfo --sync so unregistered (unactivated) devices can be automatically registered in the Console and then synced successfully, addressing issue #1368.
Changes:
- On PATCH 404 during
amtinfo --sync, POST a minimal device record (guid + hostname) and retry the PATCH. - Introduce a helper (
createDevice) to perform the minimal POST registration. - Add a unit test covering the 404 → POST → retry PATCH flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/commands/amtinfo.go | Implements 404 fallback behavior by POSTing a minimal device record then retrying the PATCH sync. |
| internal/commands/amtinfo_test.go | Adds a test validating that a 404 triggers POST registration and a retry PATCH. |
b94886d to
b1acee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1368
Output:
Query from host
Using old rpc
Using current rpc
Query from host