test: add activate fuzz coverage#1371
Draft
ShradhaGupta31 wants to merge 1 commit into
Draft
Conversation
- add fuzz targets for activate command - updated makefile & fuzz.yml to include activate fuzz test - updated cli file to include activate fuzz targets in GitHub Actions fuzz workflow Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
There was a problem hiding this comment.
Pull request overview
Adds Go fuzz-test coverage for the activate CLI command and wires the new fuzz targets into existing local (make fuzz*) and GitHub Actions fuzz workflows, following the established pattern used for deactivate.
Changes:
- Added new fuzz targets covering
activatecommand parsing/validation (flags, URL, profile, password, and combinations). - Updated
makefilefuzz targets (fuzz,fuzz-short,fuzz-regression) to run the newactivatefuzz tests. - Updated
.github/workflows/fuzz.ymlto include the new fuzz targets in both the manual-duration and regression fuzz jobs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| makefile | Runs new activate fuzz targets in existing fuzz make targets. |
| internal/cli/cli_fuzz_test.go | Adds fuzz tests for activate command inputs and flag combinations. |
| .github/workflows/fuzz.yml | Runs the new activate fuzz targets in the CI fuzz workflows. |
Comment on lines
+361
to
+364
| defer recoverPanic(t, flags) | ||
|
|
||
| _, _, err := Parse(args, mockAMTCommand) | ||
| _ = err |
Comment on lines
+403
to
+406
| defer recoverPanic(t, url) | ||
|
|
||
| _, _, err := Parse(args, mockAMTCommand) | ||
| _ = err |
Comment on lines
+440
to
+443
| defer recoverPanic(t, profile) | ||
|
|
||
| _, _, err := Parse(args, mockAMTCommand) | ||
| _ = err |
Comment on lines
+484
to
+487
| defer recoverPanic(t, password) | ||
|
|
||
| _, _, err := Parse(args, mockAMTCommand) | ||
| _ = err |
Comment on lines
+583
to
+586
| defer recoverPanic(t, strings.Join(args, " ")) | ||
|
|
||
| _, _, err := Parse(args, mockAMTCommand) | ||
| _ = err |
Comment on lines
+356
to
+359
| args := []string{"rpc", "activate"} | ||
| if trimmed := strings.TrimSpace(flags); trimmed != "" { | ||
| args = append(args, strings.Fields(flags)...) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses - #1351