Skip to content

fix(e2e): update cloud activation spec for tls-tunnel implementation#3352

Merged
lim-chris merged 1 commit into
mainfrom
v3.57.7-e2e-tls
Jun 4, 2026
Merged

fix(e2e): update cloud activation spec for tls-tunnel implementation#3352
lim-chris merged 1 commit into
mainfrom
v3.57.7-e2e-tls

Conversation

@lim-chris
Copy link
Copy Markdown
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

  1. Use -tls-tunnel flag for activate command on AMT ≤ 18 (not needed for AMT > 18)
  2. Assert TLS message by AMT version: TLS: Already Configured (≥ 19) vs TLS: Configured (< 19)
  3. Use case-insensitive regex (/i) for all assertions

Anything the reviewer should know when reviewing this PR?

AMT21-ACM: https://github.com/device-management-toolkit/e2e-testing/actions/runs/26565660967
AMT21-CCM: https://github.com/device-management-toolkit/e2e-testing/actions/runs/26568832158
AMT18-ACM: https://github.com/device-management-toolkit/e2e-testing/actions/runs/26556593783
AMT18-CCM: https://github.com/device-management-toolkit/e2e-testing/actions/runs/26557910417

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Cypress cloud activation E2E spec to align with the RPC TLS-tunnel behavior and updated activation output across AMT major versions.

Changes:

  • Adjusts activate command flags to use -tls-tunnel for AMT ≤ 18 and no extra flag for AMT > 18.
  • Updates activation output assertions to be case-insensitive and to expect different TLS messages for AMT ≥ 19 vs < 19.
  • Simplifies deactivate command construction by removing skip-cert flag detection logic.

Comment thread cypress/e2e/integration/rpc/cloud.activation.spec.ts
Comment thread cypress/e2e/integration/rpc/cloud.activation.spec.ts
@lim-chris lim-chris merged commit 3d2f199 into main Jun 4, 2026
8 checks passed
@lim-chris lim-chris deleted the v3.57.7-e2e-tls branch June 4, 2026 02:07
RosieAMT pushed a commit that referenced this pull request Jun 4, 2026
## [3.57.11](v3.57.10...v3.57.11) (2026-06-04)

### Bug Fixes

* **e2e:** update cloud activation spec for tls-tunnel implementation ([#3352](#3352)) ([3d2f199](3d2f199))
@RosieAMT
Copy link
Copy Markdown

RosieAMT commented Jun 4, 2026

🎉 This PR is included in version 3.57.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants