Conversation
…th version 5.7.0 release (#451) * Initial plan * Add iPhone 17 series and Apple Watch Ultra 3/Series 11 to Device.swift.gyb template Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com> * Fix Apple Watch Ultra 3 and Series 11 to use S10 chip instead of S11 Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com> * Add changelog entry for 5.7.0 and update version numbers - Add changelog entry for version 5.7.0 with September 12th release date - Include table of new iPhone 17 series and Apple Watch devices - Update version to 5.7.0 in README.md, DeviceKit.podspec, and project.pbxproj - Follow pattern from previous version releases Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com> * Fix changelog. * Build generated file after copilot gyb implementation. * Make iPhone Air plus sized. * More device attribute fixes. * Update tests after adding new devices. * Add changelog entry for Series 9 fix. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com> Co-authored-by: Zandor Smith <info@zsinfo.nl>
Zandor300
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .iPhone16Plus, | ||
| .iPhone16ProMax, | ||
| .iPhone17ProMax, | ||
| .iPhoneAir, |
There was a problem hiding this comment.
Collection literals should not have trailing commas.trailing_comma Tests.swift:463 |
| .iPhone17, | ||
| .iPhone17Pro, | ||
| .iPhone17ProMax, | ||
| .iPhoneAir, |
There was a problem hiding this comment.
Collection literals should not have trailing commas.trailing_comma Tests.swift:531 |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
|
Should the Air really be flagged as plus sized since it's smaller than the previous plus model and doesn't have the Plus moniker? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th version 5.7.0 release (#451)
Initial plan
Add iPhone 17 series and Apple Watch Ultra 3/Series 11 to Device.swift.gyb template
Fix Apple Watch Ultra 3 and Series 11 to use S10 chip instead of S11
Add changelog entry for 5.7.0 and update version numbers
Fix changelog.
Build generated file after copilot gyb implementation.
Make iPhone Air plus sized.
More device attribute fixes.
Update tests after adding new devices.
Add changelog entry for Series 9 fix.