Open
Conversation
Add timeout parameter to runFlow steps that propagates through the
driver interface via SetContext, enabling mid-operation cancellation
of element-finding polling loops when the timeout expires.
Example usage:
- runFlow:
file: common/login.yaml
timeout: 5000 # 5 second timeout
env:
username: devicelab
- runFlow:
timeout: 3000 # inline steps with timeout
commands:
- tapOn: "Submit"
- assertVisible: "Success"
- Add SetContext(ctx) to Driver interface and all implementations
(uiautomator2, wda, appium, devicelab, flutter, mock)
- Propagate timeout context into driver polling loops so element
finding is interrupted immediately on expiry
- Fix parser to include timeout field in runFlow raw struct
- Replace cryptic "context deadline exceeded" errors with informative
messages showing timeout value, flow file, and executing step
- Add enrichTimeoutError for sub-step error enrichment
- Timeout failures are classified as "TIMEOUT" error type in reports
(not "UNKNOWN"), enabling proper failure categorization in HTML,
JUnit, and Allure reports
- Add 4 executor tests and 2 parser tests for timeout behavior
Ref #29
Thanks to @maraujop for the suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutparameter torunFlowsteps (milliseconds) that propagates into driver polling loops viaSetContext(ctx), enabling mid-operation cancellation when the timeout expiresExample usage
Error messages
Test plan
Ref #29 — Thanks to @maraujop for the suggestion!