Add ruff BLE001 as a swallowed-exception smell#62
Merged
Conversation
Map ruff's blind-except rule to a new swallowed-exception smell with a coaching prompt. Add 'ruff' as a Rule source (first ruff-only smell, mirroring knip). Severity suggested.
devill
approved these changes
Jun 25, 2026
devill
left a comment
Owner
There was a problem hiding this comment.
Cleanly wired: new 'ruff' source is metadata-only (no double-emit), prompt auto-registers via the catalogue, changedFilesOnly/severity consistent with sibling smells. TS swallowed-exception equivalent is a separate, narrower concern (no BLE001 analog in untyped JS catch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds ruff's
BLE001(blind-except) as a newswallowed-exceptionsmell, with a coaching prompt that tells the agent what to do instead of just reporting the rule.Why
A broad
exceptthat swallows the error is a silent-failure risk. ruff already flags it; this turns the bare "Do not catch blind exception" into actionable guidance, in the habit-hooks style.Design note
swallowed-exceptionis the first smell sourced only from ruff, with no TypeScript twin (the existing ruff smells reuse an eslint or knip smell). SoRule.sourceneeded a new value. I added'ruff'toRuleSourceand to config validation, mirroring howknipis a spec-driven source. Happy to take a different approach if you'd prefer.Severity is
suggested, notenforced: blind-except has legitimate top-level uses (request handlers, worker loops), so it coaches rather than failing the run. Easy to flip.Changes
src/config/tool-smells.ts(RUFF_SPEC): addBLE001to--select,produces, and the map.src/config/catalogue.ts: newswallowed-exceptionrule (source: 'ruff').src/types.tsandsrc/config/validate.ts: add the'ruff'source.src/prompts/swallowed-exception.md: the coaching prompt.docs/smell-vocabulary.mdanddocs/DECISIONS.md: catalogue row, ruff mapping row, decision record.src/python-acceptance.test.ts: a test thatBLE001firesswallowed-exceptionand that a specific, namedexceptdoes not. Gated on ruff like the other Python tests (skipped on CI without the toolchain).Testing
Full suite green locally with ruff and deptry installed (503 passed). typecheck and lint clean.