test(hermes-plugin): force the e2e real-server child inline (#138) - #146
Merged
Merged
Conversation
test_stdio_e2e_real_server.py spawned dist/interfaces/mcp/server.js without --standalone, so on a machine with the daemon up the stdio start bridged to it and the `remember` call landed in the production database. Set ENGRAM_MCP_STANDALONE=1 via the fixture's `extra_env` so the child always runs inline against the temp ENGRAM_DB_PATH. #87 already makes an ENGRAM_SCOPE-carrying start run inline; this makes the test's hermeticity explicit rather than a side effect of that rule. Closes #138 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017FkPTUntBVpcD9ta58zaHs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interfaces/hermes-plugin/tests/test_stdio_e2e_real_server.pyspawneddist/interfaces/mcp/server.jswithout--standalone. With the daemon up on:9907, the stdio start bridged to it and the test'srememberlanded in the production database (#138).Fix:
"extra_env": {"ENGRAM_MCP_STANDALONE": "1"}in the test'sengram.jsonfixture, so the child always runs inline against the tempENGRAM_DB_PATH. #87 already runs anENGRAM_SCOPE-carrying start inline; this makes the test's hermeticity explicit rather than a side effect of that rule.Closes #138
Verification
:9907) during the run; the test wrote to the pytest temp DB (e2e-engram.db, 1.5 MB), not~/.local/share/engram/engram.db.python3 -m pytest interfaces/hermes-plugin/tests -q(withPYTHONPATH=~/.hermes/hermes-agent): 127 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_017FkPTUntBVpcD9ta58zaHs