Enforce macOS 27+ before launching fm benchmarks#5
Merged
Conversation
Refuse run/models/doctor on older macOS or non-darwin platforms with an exit code 2 message that names the detected version and the latest supported release. Offline report commands stay available everywhere.
3 tasks
Keep hard gates for run/models. Doctor still reports the detected version, latest supported macOS, and a failed fm probe when the host is too old.
Owner
Author
|
Self-review (cannot approve own PR):
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/macos.jswith a fixed minimum of macOS 27.0 for any command that launches Apple'sfmCLI.run,models, anddoctorwith exit code 2, reporting the detected version and the latest supported macOS.compare,history,validate,export,legend) usable on any platform.Test plan
npm test(58 pass)npm run lintfm-bench doctorand--profile quickon macOS 27.0sw_vers26.1 PATH override exits 2 and prints latest supported version