Apply review feedback to minimal Cortex query (P0-D)

[Copilot]

Five issues identified in the P0-D review: unsorted combined results, missing defensive docs on concatVectors, no pagination warning on getAllPages, cramped stub formatting, and missing test cases that P0-D3 claimed complete.

Changes

• cortex/Query.ts – Sort combined by descending score before building the return value; add JSDoc to concatVectors documenting the non-empty-array precondition
• storage/IndexedDbMetadataStore.ts – Add TODO on getAllPages() flagging the full-table-scan as unfit for large corpora; should be replaced with paginated/indexed access
• tests/SalienceEngine.test.ts – Reformat three stub methods crammed on one line to separate lines, consistent with the rest of the mock
• tests/cortex/Query.test.ts – Add the two tests that P0-D3 listed but were absent: empty-corpus (no results) and descending-score-order (relevance); fix pre-existing TestVectorBackend.kind type error ("test" → "wasm")

// Before: hotpath hits always preceded cold hits regardless of score
const combined = [...hotpathResults, ...coldResults];

// After: globally ranked
const combined = [...hotpathResults, ...coldResults];
combined.sort((a, b) => b.score - a.score);

---

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

[Copilot]

Pull request overview

This PR applies prior review feedback to the minimal Cortex query path by improving global result ranking, documenting a key precondition in vector concatenation, flagging an IndexedDB scalability concern, and adding missing unit tests for query behavior.

Changes:

• Sort merged hotpath + cold query results by descending score before returning.
• Document concatVectors’ non-empty/equal-length precondition and add a scalability TODO for getAllPages().
• Add/adjust unit tests for empty-corpus behavior and descending-score ordering; reformat MetadataStore stubs in an existing test.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
cortex/Query.ts	Sorts combined results by score and documents concatVectors precondition.
storage/IndexedDbMetadataStore.ts	Adds a TODO warning that getAllPages() is a full-table scan unsuitable for large corpora.
tests/SalienceEngine.test.ts	Re-formats stubbed methods for readability/consistency.
tests/cortex/Query.test.ts	Adds missing query tests and updates the test vector backend kind.