Skip to content

#1699 verify input git url#1700

Open
SDallmann wants to merge 4 commits intodevonfw:mainfrom
SDallmann:#1699-verify-input-GitUrl
Open

#1699 verify input git url#1700
SDallmann wants to merge 4 commits intodevonfw:mainfrom
SDallmann:#1699-verify-input-GitUrl

Conversation

@SDallmann
Copy link
Contributor

This PR fixes #1699

Implemented changes:

  • Added the functionality to verify that the input Git URL is valid, i.e. it start with http, https, ssh or @git.
    If the input URL isn't valid, the user will be requested to provide the URL again.
  • Added unit tests for this functionality.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Feb 3, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21624876932

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.444%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/git/GitUrl.java 3 87.93%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 20 82.04%
Totals Coverage Status
Change from base Build 21513109358: -0.002%
Covered Lines: 10490
Relevant Lines: 14306

💛 - Coveralls

@lubska
Copy link
Contributor

lubska commented Feb 6, 2026

I´ve checked the code and there are no comments on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Add function to verify that the provided git URL is valid

4 participants