fix: resolve Octane Alpine Docker build dependencies#45
Merged
ibourgeois merged 2 commits intomainfrom Apr 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Alpine-based Octane Docker builds by ensuring the generated Octane Dockerfile installs the missing Alpine development packages needed to compile Swoole on php:8.4-cli-alpine, and adds regression test coverage to prevent the packages from being dropped in future stub edits.
Changes:
- Add
brotli-devandopenssl-devto the Octane Dockerfile stub beforepecl install swoole. - Extend the Dockerfile generator unit test to assert the Octane output includes these dependencies (and keeps them in the expected
apk addblock).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
stubs/docker/octane.Dockerfile.stub |
Adds Alpine dev packages required for Swoole compilation (Brotli + OpenSSL) in the Octane image. |
tests/Unit/Docker/DockerfileGeneratorTest.php |
Adds assertions to ensure the generated Octane Dockerfile continues to include these packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php:8.4-cli-alpineTesting
Manual validation:
libbrotliencandlibsslconfigure failures and into the long Swoole compile stageCloses #44