Skip to content

Rewrite d3 wrapper to work with current version of d3.js and be better in general#295

Open
emilydolson wants to merge 145 commits intomasterfrom
d3-wrapper
Open

Rewrite d3 wrapper to work with current version of d3.js and be better in general#295
emilydolson wants to merge 145 commits intomasterfrom
d3-wrapper

Conversation

@emilydolson
Copy link
Copy Markdown
Collaborator

This is the pull request for Elizabeth and Oliver's WAVES project, in which they are re-writing the d3 wrapper from the ground up to make it work with the new version of d3 while also making a variety of other improvements along the way.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 25, 2021

Codecov Report

❌ Patch coverage is 78.51576% with 634 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (223f54c) to head (f13b4b8).
⚠️ Report is 2350 commits behind head on master.

Files with missing lines Patch % Lines
include/emp/web/d3/selection.hpp 30.29% 168 Missing ⚠️
include/emp/web/d3/svg_shapes.hpp 6.85% 163 Missing ⚠️
include/emp/web/d3/scales.hpp 66.81% 153 Missing ⚠️
include/emp/web/d3/transition.hpp 0.00% 120 Missing ⚠️
include/emp/web/d3/d3_init.hpp 69.76% 13 Missing ⚠️
include/emp/web/js_utils.hpp 50.00% 7 Missing ⚠️
include/emp/web/CanvasShape.hpp 0.00% 2 Missing ⚠️
include/emp/web/d3/axis.hpp 98.71% 2 Missing ⚠️
tests/web/d3/selection.cpp 98.27% 2 Missing ⚠️
tests/web/d3/shapes.cpp 95.45% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   82.96%   82.64%   -0.33%     
==========================================
  Files         306      319      +13     
  Lines       37356    40565    +3209     
==========================================
+ Hits        30994    33526    +2532     
- Misses       6362     7039     +677     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants