Skip to content

refactor: organize notification classes with cn#156

Merged
Aditya948351 merged 1 commit into
devpathindcommunity-india:masterfrom
saurabhhhcodes:refactor/tailwind-class-merge-129
May 20, 2026
Merged

refactor: organize notification classes with cn#156
Aditya948351 merged 1 commit into
devpathindcommunity-india:masterfrom
saurabhhhcodes:refactor/tailwind-class-merge-129

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Summary

  • refactors the notification dropdown unread-state classes to use the existing cn helper
  • moves notification type gradient classes into a typed lookup map instead of an inline nested ternary
  • replaces the loose notification timestamp type with Firestore Timestamp while touching the component

Closes #129

Validation

  • npx eslint src/components/NotificationDropdown.tsx
  • git diff --check
  • npm run build compiled successfully, then stopped during prerender because local Firebase env keys are not configured (auth/invalid-api-key)

Suggested GSSoC labels

gssoc:approved, level:beginner, type:refactor, quality:clean

@Aditya948351 Aditya948351 merged commit 23b7807 into devpathindcommunity-india:master May 20, 2026
4 checks passed
@saurabhhhcodes

Copy link
Copy Markdown
Contributor Author

Thanks for merging this. For GSSoC scoring, could you please add the labels when you get a chance? Suggested labels: gssoc:approved, level:beginner, type:refactor, quality:clean.

@saurabhhhcodes

Copy link
Copy Markdown
Contributor Author

Thanks for merging this cleanup. This refactor keeps the notification styling consistent through the shared cn helper, so could you please add the missing GSSoC scoring labels when you get a chance? I think gssoc:approved, level:beginner, and type:refactor fit the actual change.

@Aditya948351

Copy link
Copy Markdown
Collaborator

Yeah adding those labels @saurabhhhcodes !

@Aditya948351 Aditya948351 added gssoc26 This is a official GirlScript Summer of Code label. gssoc:approved give 50+ base points level:beginner Beginner level issues good first issue quality:clean type:refactor labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue gssoc:approved give 50+ base points gssoc26 This is a official GirlScript Summer of Code label. level:beginner Beginner level issues quality:clean type:refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Consolidate long Tailwind class strings using tailwind-merge

2 participants