refactor: organize notification classes with cn#156
Merged
Aditya948351 merged 1 commit intoMay 20, 2026
Merged
Conversation
23b7807
into
devpathindcommunity-india:master
4 checks passed
Contributor
Author
|
Thanks for merging this. For GSSoC scoring, could you please add the labels when you get a chance? Suggested labels: |
Contributor
Author
|
Thanks for merging this cleanup. This refactor keeps the notification styling consistent through the shared |
Collaborator
|
Yeah adding those labels @saurabhhhcodes ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cnhelperTimestampwhile touching the componentCloses #129
Validation
npx eslint src/components/NotificationDropdown.tsxgit diff --checknpm run buildcompiled successfully, then stopped during prerender because local Firebase env keys are not configured (auth/invalid-api-key)Suggested GSSoC labels
gssoc:approved,level:beginner,type:refactor,quality:clean