perf(ui): enforce aspect-ratio utilities on image wrappers to eliminate CLS (Closes #661)#687
Open
abhinavkdeval08-design wants to merge 2 commits into
Conversation
…te CLS (Closes devpathindcommunity-india#661) Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #661.
Audited the core UI components for progressive rendering issues. Replaced non-dimensional containers with strict
aspect-videoandaspect-squareTailwind utility classes on Next.js<Image>wrappers. This ensures that the exact bounding box is reserved before the image fetch completes, effectively eliminating Cumulative Layout Shift (CLS) during progressive rendering and improving overall Lighthouse UX metrics.Type of change
How Has This Been Tested?
Checklist: