fix(a11y): resolve generic Action button ARIA labels across the application#688
Open
just-tanvi wants to merge 1 commit into
Open
fix(a11y): resolve generic Action button ARIA labels across the application#688just-tanvi wants to merge 1 commit into
fix(a11y): resolve generic Action button ARIA labels across the application#688just-tanvi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Overview
This PR fixes a widespread accessibility issue where the generic
aria-label="Action button"attribute was override-masking visible button text, preventing screen readers from announcing correct actions. All buttons have been updated to adhere to WCAG 2.1 Success Criteria 4.1.2 (Name, Role, Value) and 1.1.1 (Non-text Content).Details
aria-label="Action button"occurrences removed: 139+ occurrences.aria-label="Action button"attribute entirely to allow standard text nodes (e.g. "Submit Project", "Save", "Cancel") to naturally serve as the accessible name.Close modal/Close searchSearchToggle themeDelete item/Delete user/Delete eventFollow/UnfollowNext step/Previous stepOpen menu/Close menuTest & Build Verification
npm run build).login.spec.tsandroadmap.spec.ts).closes #684