fix(auth): prevent infinite loading hang on Firestore snapshot error#689
Open
just-tanvi wants to merge 1 commit into
Open
fix(auth): prevent infinite loading hang on Firestore snapshot error#689just-tanvi wants to merge 1 commit into
just-tanvi wants to merge 1 commit into
Conversation
github-actions
Bot
added
gssoc26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Firestore
onSnapshotlistener insrc/context/AuthContext.tsxlacked an error callback. Currently,setIsLoading(false)is only called inside the success callback. If the snapshot fails during initialization (due to permission issues, network interruptions, deleted document, or Firestore errors), the success callback is never executed and the application remains stuck in a loading spinner state indefinitely.Solution
onSnapshotlistener.setIsLoading(false)is called upon error to resolve the loading spinner state and logged the sync error to the console.src/context/__tests__/AuthContext.test.tsxby mocking bothonSnapshotsuccess and failure conditions to guarantee thatsetIsLoading(false)resolves properly in all cases.Verification Results
npm test): All 19 tests passed, including new test cases for loading-state resolution.npm run test:e2e): All 28 Playwright tests passed successfully.npm run build): Compiled successfully with complete TypeScript and Next.js static asset checks.closes #686