Skip to content

feat: Add CI check and PR template for leaderboard submissions. - #16

Open
jonmaaku-rev wants to merge 2 commits into
mainfrom
feat/leaderboard-submission-ci
Open

feat: Add CI check and PR template for leaderboard submissions.#16
jonmaaku-rev wants to merge 2 commits into
mainfrom
feat/leaderboard-submission-ci

Conversation

@jonmaaku-rev

@jonmaaku-rev jonmaaku-rev commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

https://app.devrev.ai/devrev/works/ISS-350408

Validate leaderboard row entries on any PR that touches leaderboard files, enforcing the structural contract reviewers previously checked by hand:

  • scripts/validate_leaderboard.py: offline validator for entries under leaderboard/entries/ — job header (source UUID + matching public Harbor URL), n_trials == unique trial_ids (no duplicates within a file or across entries), required agent/model/org metadata are filled, and metrics conform to the metrics_schema in leaderboard/leaderboard.yaml.
  • .github/workflows/leaderboard.yml: dedicated workflow, path-filtered to leaderboard entries, the schema, and the validator, so unrelated PRs are unaffected.
  • .github/PULL_REQUEST_TEMPLATE/leaderboard_submission.md: selectable PR template carrying the full submission checklist (automated + manual review items, including timeout-multiplier comparability rules).
  • Makefile: add validate-leaderboard target (kept out of validate to avoid a double run).
  • CONTRIBUTING.md, docs/submit-results.md: pot contributors to the template and note which items CI now checks automatically.

Summary

Type of contribution

  • Task addition or update
  • Dataset addition or update
  • Agent result submission
  • Documentation
  • Bug fix / setup improvement
  • Other

Validation

  • make validate passes
  • I ran at least one affected task, or explained why not below
  • Dataset changes are synthetic and safe to publish
  • New/changed task criteria avoid answer leakage
  • Documentation is updated

Commands run

# Paste commands and outcomes here

Notes for reviewers

Validate leaderboard row entries on any PR that touches leaderboard
files, enforcing the structural contract reviewers previously checked
by hand:

- scripts/validate_leaderboard.py: offline validator for entries under
  leaderboard/entries/ — job header (source UUID + matching public
  Harbor URL), n_trials == unique trial_ids (no duplicates within a file
  or across entries), required agent/model/org metadata are filled, and
  metrics conform to the metrics_schema in leaderboard/leaderboard.yaml.
- .github/workflows/leaderboard.yml: dedicated workflow, path-filtered to
  leaderboard entries, the schema, and the validator, so unrelated PRs
  are unaffected.
- .github/PULL_REQUEST_TEMPLATE/leaderboard_submission.md: selectable PR
  template carrying the full submission checklist (automated + manual
  review items, including timeout-multiplier comparability rules).
- Makefile: add validate-leaderboard target (kept out of validate to
  avoid a double run).
- CONTRIBUTING.md, docs/submit-results.md: pot contributors to the
  template and note which items CI now checks automatically.
r"^#\s*(https://hub\.harborframework\.com/jobs/([0-9a-fA-F-]{36}))\s*$",
re.MULTILINE,
)
UUID_RE = re.compile(r"^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a library that can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant