UI: Replace 'Fork me on GitHub' ribbon with modern icon (#437) #444
+35
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@wurstbrot Plz Review the changes |
vbakke
reviewed
Dec 21, 2025
src/index.html
Outdated
| <link rel="preconnect" href="https://fonts.gstatic.com" /> | ||
| <link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet" /> | ||
| <link href="https://fonts.googleapis.com/icon?family=Material+Icons|Material+Icons+Outlined" rel="stylesheet" /> | ||
| <!-- <link rel="stylesheet" |
Collaborator
There was a problem hiding this comment.
Thank you. Please remove the code completely, and I'll approve 🙂👍
src/app/app.component.css
Outdated
| background-color: #333; | ||
| .github-button img { | ||
| margin-right: 20px; | ||
| height: 35px; |
Collaborator
There was a problem hiding this comment.
Nice! 🙂
The 35px draws a lot of attention. More than a 'Fork me' I think needs.
I propose:
margin-right: 0px;
height: 20px;
What do you think?
Author
There was a problem hiding this comment.
I have removed the dade code from"src/index.html'
And I think we should add some margin from right to the GitHub, icon, and I resized the icon and 20px height is too small, that's why I gave it 30px height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the user interface by removing the legacy "Fork me on GitHub" corner ribbon and replacing it with a clean, modern GitHub icon. This change improves the visual aesthetic and fixes layout issues on the Overview page.
Changes Made
Closes #437