Fix: Improve logo visibility in Dark Mode (#435) #445
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@wurstbrot Plz Review the changes |
vbakke
requested changes
Dec 21, 2025
Collaborator
vbakke
left a comment
vbakke
left a comment
There was a problem hiding this comment.
I appretiate a second view on the dark mode. It is quite recent, and deserves a review.
However, the bright #fff white in the logo is too harsh on the eye. Better use the grey tinten colord from the text below. Then we keep the same style on the whole page.
Also, I don't quite see the need to fiddle with the logo. The darker shades are harder on the eye that the original in dark mode
Author
|
Ok let me do that thank you for your openioun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the low contrast issue where the DSOMM logo text was invisible in the Dark Mode.
Closes #435