(sidebar): keep session-meta children in a fixed order whether the status slot is populated or not - #287
Merged
Conversation
…atus slot is populated or not The status span is now always rendered (empty when absent) and pinned right with margin-left:auto; the container no longer uses space-between, so the short id no longer moves between the middle and the far right depending on whether that row currently has a live process. Closes #286.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286.
.session-metausedjustify-content: space-betweenover two or three children depending on whethersession.statuswas set on that row, so the short id sat at the far right on rows without a live process and in the middle on rows with one. Local and remote rows evaluate that condition independently, which is what produced the visible shift between neighbouring rows.buildSessionItemalways renders the status span (empty when absent), in the fixed order time → short id → status..session-metais now a plaingapflex row;.session-statuscarriesmargin-left: autoand hugs the right edge whether it has text or not. Net visual change: the short id now sits next to the time on every row instead of jumping..session-metaand were never affected; grid view does not use.session-meta.dom-sidebar-local-status.test.jsasserts the same three children in the same order with and without status;session-meta-layout-css.test.jspins the CSS..ai/contexts/session-state.md.