feat(dsoc): complete proposal portal end-to-end#42
Merged
Conversation
Closes the loop on the DSOC proposal flow so students can submit, track status, and read mentor feedback, and mentors get a real review screen instead of a 404. - Add /dsoc/applications/[id] mentor + admin review page with full proposal, applicant context, status update, score, and notes - Persist motivation, technicalSkills, githubProfile, timeline, challenges, timezone, startDate on DSOCApplication so the apply form fields stop getting silently dropped by mongoose strict mode - Strip empty-string optional fields on POST so Date casts don't blow up when the mentee skips the optional start date - Mentee dashboard now surfaces mentor feedback, score, and review date on each application card once it's been reviewed - Fix unauthenticated `?my=true` returning every application in the database; require a valid mentee session
ZeeshanAdilButt
force-pushed
the
dsoc-proposal-portal
branch
from
bf0371b to
351d3e2
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the loop on the DSOC proposal flow. Before this PR, the apply form posted fields that mongoose silently dropped, the mentor dashboard linked to a 404, and mentees never saw any feedback after their application was reviewed.
/dsoc/applications/[id]— full proposal, applicant context, status update, score, notes, accept/reject actions. The mentor dashboard already links here.DSOCApplicationnow persistsmotivation,technicalSkills,githubProfile,timeline,challenges,timezone,startDate. These were posted by the apply form but dropped by mongoose strict mode.startDate) are dropped before save so the Date cast doesn't throw.mentorNotes,score, and review date inline once a proposal has been reviewed.GET /api/dsoc/applications?my=truewith no mentee session was returning every application in the database. Now requires auth.Roles after this change
/dsoc/apply/[id], see status + feedback on/dsoc/mentee/dashboard./dsoc/mentor/dashboardand open the full proposal at/dsoc/applications/[id]to set status, score, and notes.Test plan
/api/dsoc/applications?my=truewithout a mentee cookie returns 401, not data🤖 Generated with Claude Code