docs: document Docker gomplate configuration#4759
Conversation
nabokihms
left a comment
There was a problem hiding this comment.
@AkashKumar7902, hello and thank you for submitting the PR!
The README file is not the place for this kind of a doc. Please consider moving it to https://dexidp.io/docs/configuration/
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
1f1887c to
944ed70
Compare
|
@nabokihms Thanks! You're right — I removed the README block. The PR now only adds a small inline comment in I'll open a follow-up against the docs site to add the gomplate / |
cardoe
left a comment
There was a problem hiding this comment.
I don't find it helpful to have this in a comment. It would be better to include something in the docs site.
Overview
Closes #2645.
What this PR does / why we need it
.yaml,.tpl, and.tmplconfig arguments with gomplate before starting dex.$VARconfig expansion.Special notes for your reviewer
Validation:
go test ./cmd/docker-entrypoint -run TestRun -count=1go test ./cmd/dex -run "TestUnmarshalConfigWithEnv(NoExpand|Expand)$" -count=1git diff --check