feat(gitlab): support inherited group claims#4800
Open
AntonKulyashov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anton Kulyashov <anton.kulyashov@flant.com>
0c361fd to
42d0f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add inherited group support to the GitLab connector.
What this PR does / why we need it
GitLab's
/oauth/userinforesponse only includes groups where the user is a direct member. This means Dex can miss inherited group memberships and reject users when group filtering depends on subgroup membership inherited from a parent group.This PR adds an
inheritedGroupsoption to the GitLab connector. When enabled, Dex uses/api/v4/groupsas the source of truth for group names so inherited memberships are included. To support that flow, the connector requestsread_apiin addition to the existingread_userandopenidscopes.This PR also keeps
getGroupsPermissionworking with inherited groups. Dex first uses permission claims from/oauth/userinfowhere possible, and only falls back to per-group effective membership lookups when needed. If GitLab returns403or404for one of those fallback permission lookups, Dex skips the suffix for that group instead of failing the entire authentication flow.Tests were added for: