Stop the map compass drawing over the account avatar - #71
Merged
Conversation
Leaving `compass` unset doesn't leave the compass off: the native view only forwards the prop when it's non-null, so MapLibre's own default takes over — enabled, and merely faded out while the map faces north. Devices that skip that fade animation draw it for real, as a disc sitting over the top-right corner behind the account button. Seen on a Viwoods Paper e-ink tablet. We never rotate the map, so there's nothing for a compass to say. Turn it off explicitly rather than relying on an animation to hide it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a Viwoods Paper e-ink tablet a solid black disc sits in the top-right corner, behind the account avatar. It's MapLibre's compass ornament.
Measuring the screenshot pinned it down: the disc is 40dp with a ~6.5dp right margin and a top of
42dp (status bar inset) + 6.5dp, which matches the native MapLibre attribution ornament's margin — not the avatar'sright: 16. So it's a native map ornament, not app chrome.We never passed
compass, and leaving it unset doesn't leave the compass off.MLRNMapView.kt:1272only callssetCompassEnabledwhen the prop is non-null, so MapLibre's own default takes over: enabled, and merely faded out while the map faces north. Devices that skip that fade animation draw it for real.We never rotate the map, so
compass={false}explicitly rather than relying on an animation to hide it.Testing
tsc --noEmit,biome check, and all 51 tests pass.Not addressed
The other half of the report — no recenter button in the bottom-right on this device — is not a render bug.
MapScreen.tsx:534gates it onposition, which requires a location fix; the device was in airplane mode and showed no<UserLocation>puck either. Whether the tablet can get a fix at all is a separate question.