Hold java on Adoptium mainline LTS via a renovate rule that actually matches - #78
Merged
Conversation
The rule added in #76 to keep java off Adoptium's respins never fired: the mise manager reports this dep as depName `java` but packageName `java-jdk`, and matchPackageNames tests the packageName, so the rule was inert and Renovate kept offering 25.0.4+101.0.LTS (PR #75, which fails `mise install` on linux/x64 nine seconds into both CI jobs). Matching on matchDepNames is what binds the rule to the dep. With the rule live, the respin is filtered and the next candidate is the non-LTS major 26.0.2+10 — not something the Android build JDK should drift onto. A single allowedVersions regex covers both cases by admitting only mainline LTS builds: three-part version, 1-2 digit build (respins encode as `patch * 100 + build`, landing at +1xx), `.0.LTS` suffix. Verified against the live Adoptium version list with `RENOVATE_PLATFORM=local renovate`: at the current pin no update is offered, and from an older pin (25.0.1+8.0.LTS) the mainline 25.0.4+7.0.LTS patch still comes through. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why #75 fails
PR #75 (
java→25.0.4+101.0.LTS) is Adoptium's interim respinjdk-25.0.4.1+1, built for alpine-linux/x64 and mac/x64 only. mise resolves java per platform, so on linux/x64 there is no metadata at all andmise installhard-fails before any build step — both CI jobs die nine seconds in:mise ls-remote javaconfirmstemurin-25.0.4+7.0.LTSis still the newest 25.x build available here.Why the existing rule didn't stop it
#76 added a rule for exactly this, but it never fired. The mise manager reports this dep as depName
java, packageNamejava-jdk, andmatchPackageNamestests the packageName — somatchPackageNames: ["java"]silently matched nothing. Confirmed by running Renovate 43.288.0 (the version CI uses) locally at debug level: with main's config it still resolvesnewValue: 25.0.4+101.0.LTS. That also explains why yesterday's Renovate run left #75 open instead of pruning it.matchDepNamesis what binds the rule to the dep.Why LTS-only
With the rule live, the respin is filtered and the next candidate becomes the non-LTS major
26.0.2+10— masked until now, and not something the Android build JDK should drift onto. OneallowedVersionsregex covers both cases by admitting only mainline LTS builds:25.0.4+7.0.LTS25.0.4+101.0.LTSpatch * 100 + buildlands at +1xx)26.0.2+10Verification
RENOVATE_PLATFORM=localruns against the live Adoptium version list:25.0.4+7.0.LTS) →0 flattened updates found25.0.1+8.0.LTS) → offers25.0.4+7.0.LTS, so mainline LTS patches still come throughgradle, so the<9.7ceiling is finebunx tsc --noEmit,bun run lint,bun run test -- --ci(51 tests) all pass.Once this lands, Renovate should autoclose #75 on its next run; it can also be closed by hand.
🤖 Generated with Claude Code