refactor: scan a single input directory#78
Merged
Conversation
The sync plugin enforces exactly one input directory, so `scan()` no longer needs to merge multiple trees. Take a single `dir: &str` instead of `dirs: &[String]`, and drop the `seen_keys` cross-dir duplicate-key guard — within one tree walk, distinct paths always yield distinct keys, so that check was unreachable. Removes the two tests that only exercised multi-dir merging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scan()now takes a singledir: &strinstead ofdirs: &[String].The sync plugin already enforces exactly one input directory (the
[d] => dmatch insync()), soscan()never had more than one tree to walk. This drops the now-pointless multi-dir machinery:for dir in dirsloop.seen_keysHashSetand its duplicate-key error path. Within a single tree walk, distinct filesystem paths always yield distinct keys, so the cross-dir collision check was unreachable.walk()loses itsseen_keysparameter.sync()passes the validated singledirtoscan()and logsfrom {dir}instead of the{:?}slice debug.Tests
Removed the two tests that only existed to exercise multi-dir merging (
duplicate_key_across_two_source_dirs,multiple_source_dirs). Remainingscantests updated to the single-dir signature.cargo test -p sync-core— 188 passed.🤖 Generated with Claude Code