Conversation
Now that I've bought a domain, I guess it needs to run on the root?
Prevously it was running on
https://dgmstuart.github.io/bingo-frontend/
...and now it's just
https://teamlindybingo.com/
ROUTING:
To prevent infinite rewrites we need to set pathSegmentsToKeep back to
0, otherwise we get infinite ~and~ being added:
https://teamlindybingo.com/balboa/?/&/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/~and~/
https://github.com/rafgraph/spa-github-pages/blob/v6.1.0/404.html#L18-L24
CNAME:
When adding the custom domain in the Github UI, it creates a commit
adding a CNAME file with the domain. But it adds it to the gh-pages
branch, so every time I build the app, it disappears and we lose the
custom domain.
By putting this file in /public, it gets generated in the final
distribution, so the custom domain persists.
Make the top left corner yellow. Use a gradient to make the corner a little fuzzy. I don't like how much shotgun surgery this involved.
This is kind of cool but maybe too busy, even with the flag taking up only half the square.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't look great:
