fix(ratel): correct Ingress rule host placement and example values#133
Open
nicolaelapteanu wants to merge 2 commits intodgraph-io:mainfrom
Open
fix(ratel): correct Ingress rule host placement and example values#133nicolaelapteanu wants to merge 2 commits intodgraph-io:mainfrom
nicolaelapteanu wants to merge 2 commits intodgraph-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the standalone Ratel chart Ingress template so
ingress.hosts[].hostis rendered in the correct place in the Kubernetes Ingress rules structure. Also repairs the ALB example values file so it is valid when passed withhelm install -f.Problem
hostwas emitted under thehttpblock (alongsidepaths), which does not match the Ingress API. Controllers would not apply the hostname as intended, so custom hosts (e.g. behind HAProxy Ingress class) appeared broken even when set in values.Solution
host: ...+http: ..., orhttp: ...only when no host is setpathsunchanged underhttpingress:key in:example_values/ingress/ingress-alb-no_host.yaml