Make diff-hl-timer buffer-local - #300
Merged
Merged
Conversation
Owner
|
Hi! Thanks for this. I've added a small follow-up which ensures that the update is only done once. Otherwise each applicable major mode in derived-mode chain invokes it (debouncing this is the reason the timer was introduced in the first place). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
diff-hl-timerbuffer-local so a pending timer in one buffer does not preventdiff-hl-update-oncefrom scheduling an update in another.I discovered this while using
(setq diff-hl-update-async t)and I noticed that newly opened buffers would not receive highlights until their first save.I added a test that verifies that
diff-hl-update-onceschedules an independent timer for each buffer.