Skip to content

fix: [DHIS2-19467] form inconsistencies#4061

Merged
JoakimSM merged 1 commit intomasterfrom
DHIS2-19467
May 15, 2025
Merged

fix: [DHIS2-19467] form inconsistencies#4061
JoakimSM merged 1 commit intomasterfrom
DHIS2-19467

Conversation

@JoakimSM
Copy link
Copy Markdown
Member

@JoakimSM JoakimSM commented Apr 28, 2025

  • Ensures form initialisation executes before rules.
  • Ensures all fields have a valid Redux state for formsSectionsFieldsUI.

I couldn't reproduce the error reported in the newest Capture app (in the versions mentioned in the ticket I could). However, the code was highly error-prone and didn't behave as intended. @MatiasArriola: Thanks for such a thorough description in this PR (EyeSeeTea#4)

@JoakimSM JoakimSM added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Apr 28, 2025
@JoakimSM JoakimSM changed the title fix: [DHIS2-19467] form inconsistencies fix: [DHIS2-19467] [e2e record] form inconsistencies Apr 28, 2025
@JoakimSM JoakimSM changed the title fix: [DHIS2-19467] [e2e record] form inconsistencies fix: [DHIS2-19467] form inconsistencies Apr 28, 2025
@JoakimSM JoakimSM removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Apr 28, 2025
@sonarqubecloud
Copy link
Copy Markdown

@JoakimSM JoakimSM marked this pull request as ready for review April 29, 2025 14:05
@JoakimSM JoakimSM requested a review from a team as a code owner April 29, 2025 14:05
Copy link
Copy Markdown
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
P.S. Excellent findings in this PR, @MatiasArriola!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.39.10 ,2.40.8,2.41.4,2.42.1,2.43 versions

@JoakimSM JoakimSM merged commit 1560585 into master May 15, 2025
56 of 75 checks passed
@JoakimSM JoakimSM deleted the DHIS2-19467 branch May 15, 2025 12:00
dhis2-bot added a commit that referenced this pull request May 15, 2025
## [102.4.3](v102.4.2...v102.4.3) (2025-05-15)

### Bug Fixes

* [DHIS2-19467] form inconsistencies ([#4061](#4061)) ([1560585](1560585))
* [DHIS2-19530] deprecated api query params ([#4063](#4063)) ([8400dd8](8400dd8))
@dhis2-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 102.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

devin-ai-integration Bot pushed a commit that referenced this pull request May 27, 2025
* [DHIS2-19467] form inconsistencies ([#4061](#4061)) ([1560585](1560585))
* [DHIS2-19530] deprecated api query params ([#4063](#4063)) ([8400dd8](8400dd8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants