Fix last session file for a prosession_dir with no trailing slash#117
Merged
dhruvasagar merged 1 commit intodhruvasagar:masterfrom Jan 7, 2026
Merged
Conversation
Owner
|
@jdholtz Thanks for adding this, the PR looks good however the build is broken, i'll take a look and share my thoughts accordingly. |
Contributor
Author
|
Sounds good. I can’t figure out what’s going wrong there. The tests pass locally for me and the failing test doesn’t seem to have to do with my modifications. |
Owner
|
@jdholtz The test failure was a separate issue, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting
g:prosession_dirto a custom directory without a trailing slash, this causes the last session file to be saved as<directory>last_session.txt(notice no/between<directory>andlast_session.txt.This PR uses the
fnamemodifyto ensure a path separator is appended at the end (while still expanding~).With my configuration, I had:
which caused the last_session file to be saved under
~/.local/share/nvim/site/sessionlast_session.txt.