🛡️ Sentinel: [CRITICAL] Fix DoS via Rate Limiter Proxy Null Client#155
🛡️ Sentinel: [CRITICAL] Fix DoS via Rate Limiter Proxy Null Client#155dhruvhaldar wants to merge 1 commit into
Conversation
Prevents a DoS vulnerability where `request.client` being `None` (common behind certain proxies or in serverless environments) causes an unhandled `AttributeError` leading to a 500 Internal Server Error instead of enforcing the rate limit. Co-authored-by: dhruvhaldar <29486085+dhruvhaldar@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09cf0564e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Limits requests to RATE_LIMIT_REQUESTS per RATE_LIMIT_DURATION per IP. | ||
| """ | ||
| client_ip = request.client.host | ||
| client_ip = request.client.host if getattr(request, "client", None) else "unknown" |
There was a problem hiding this comment.
When the ASGI adapter supplies request.client is None and there is no X-Forwarded-For header, this assigns every such request to the literal "unknown" key. Since the limiter allows only 20 requests per 60 seconds per key, one caller can consume that shared bucket and cause unrelated clients in the same null-client environment to receive 429s, preserving the DoS path as a global throttle rather than 500s. Prefer rejecting unidentified requests or deriving a stable trusted client key before entering the per-IP store.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The rate limiter middleware attempted to access
request.client.hostdirectly. In certain deployment environments (e.g., AWS API Gateway, some serverless proxies),request.clientcan beNone. When this occurred, accessing.hostraised anAttributeError(Internal Server Error 500) rather than enforcing the rate limit.🎯 Impact: Attackers could bypass rate limiting or cause a denial of service (DoS) by forcing a null client connection and triggering continuous 500 errors.
🔧 Fix: Added a fallback check:
client_ip = request.client.host if getattr(request, "client", None) else "unknown".✅ Verification: Verified by passing all backend tests. A specific test simulating a
Noneclient was added and verified passing.PR created automatically by Jules for task 189758354769900056 started by @dhruvhaldar